fix(docker): assemble driver on the host for docker builds#1930
Merged
Conversation
The docker image build has neither npm nor curl, only wget. Resolve the upstream gitHead via the npm registry HTTP API and fetch the upstream build script through the existing wget-or-curl helper.
Revert the npm-free download in favor of calling download_driver.sh from build.sh; the Dockerfile picks up the assembled driver via 'COPY . /tmp/pw-java'.
yury-s
changed the title
dgozman
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download_driver.shrequires npm, which the docker image build doesn't have —Test (jammy/noble)jobs fail withnpm: command not found.build.sh, which runs on the host where npm is available; the image picks up the assembled driver via the existingCOPY . /tmp/pw-java.publish_docker.sh, which funnel throughbuild.sh.